Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

additions to sphere module #271

Merged
merged 12 commits into from
Sep 21, 2023
Merged

additions to sphere module #271

merged 12 commits into from
Sep 21, 2023

Conversation

selipot
Copy link
Member

@selipot selipot commented Sep 18, 2023

Additions to the sphere module:

coriolis_frequency
tangentplane_to_sphere
sphere_to_tangentplane

@selipot selipot added the enhancement New feature or request label Sep 18, 2023
@selipot selipot added the archive-label-analysis-functions Oceanographic Lagrangian analysis functions label Sep 18, 2023
@selipot selipot requested a review from milancurcic September 18, 2023 23:00
@selipot selipot self-assigned this Sep 18, 2023
@selipot selipot changed the title first commit additions to sphere module Sep 18, 2023
@selipot
Copy link
Member Author

selipot commented Sep 18, 2023

Argh, I don't know why this PR contains commits related to the documentation :(

@philippemiron
Copy link
Contributor

philippemiron commented Sep 19, 2023

You should be able to sync your main branch, then rebase the branch of this PR with main.

@milancurcic
Copy link
Member

Don't worry too much about docs commits, we can ignore them during the review.

@milancurcic milancurcic marked this pull request as ready for review September 19, 2023 13:55
clouddrift/sphere.py Outdated Show resolved Hide resolved
clouddrift/sphere.py Outdated Show resolved Hide resolved
clouddrift/sphere.py Outdated Show resolved Hide resolved
Copy link
Member Author

@selipot selipot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

clouddrift/sphere.py Outdated Show resolved Hide resolved
clouddrift/sphere.py Outdated Show resolved Hide resolved
clouddrift/sphere.py Outdated Show resolved Hide resolved
clouddrift/sphere.py Outdated Show resolved Hide resolved
clouddrift/sphere.py Outdated Show resolved Hide resolved
milancurcic and others added 4 commits September 21, 2023 11:28
Co-authored-by: Philippe Miron <philippemiron@gmail.com>
Co-authored-by: Philippe Miron <philippemiron@gmail.com>
Co-authored-by: Philippe Miron <philippemiron@gmail.com>
Co-authored-by: Philippe Miron <philippemiron@gmail.com>
earth rotation constant

Co-authored-by: Milan Curcic <caomaco@gmail.com>
@milancurcic milancurcic merged commit b4e08d2 into Cloud-Drift:main Sep 21, 2023
10 checks passed
philippemiron added a commit to philippemiron/clouddrift that referenced this pull request Nov 16, 2023
* add wavelet module to doc?

* fix the few warnings after generating the doc

* lint

* first commit

* Fix indentation

* remove warnings

* Remove warning from docstring

Co-authored-by: Philippe Miron <philippemiron@gmail.com>

* Fix typo

Co-authored-by: Philippe Miron <philippemiron@gmail.com>

* Fix typo

Co-authored-by: Philippe Miron <philippemiron@gmail.com>

* Update clouddrift/sphere.py

Co-authored-by: Philippe Miron <philippemiron@gmail.com>

* Update clouddrift/sphere.py

earth rotation constant

Co-authored-by: Milan Curcic <caomaco@gmail.com>

---------

Co-authored-by: Philippe Miron <philippe.miron@dtn.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Philippe Miron <philippemiron@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archive-label-analysis-functions Oceanographic Lagrangian analysis functions enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants